🌱 Add integration tests for the apiexport controller #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
kcp-ci-bot
added
the
dco-signoff: yes
Contributor
Author
|
/test all |
kcp-ci-bot
added
the
size/XXL
xrstf
changed the title
xrstf
changed the title
… the CRD must be served/stored On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
…o prevent port conflicts in parallel tests On-behalf-of: @SAP [email protected]
xrstf
force-pushed
the
more-e2e-tests
branch
from
158743a to
8513c2a
Compare
kcp-ci-bot
added
size/L
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
On-behalf-of: @SAP [email protected]
kcp-ci-bot
added
size/XL
Contributor
|
LGTM label has been added. Git tree hash: 6f556cb687055f23523223ef6351e44770d5aeb0
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#22 made it possible, so now this PR adds more e2e tests. And I also identified the first few bugs in the agent thanks to the tests :-)
In addition to the tests, this PR also extends the FAQ because I saw many temporary errors in the agent log files, but when I checked, they were indeed temporary. Also I checked, an APIExport gets ready & virtualWorkspaceURLsReady immediately after creation, so there isn't really anything the agent could do to delay its own setup and wait for the APIs to be actually available.
There are now also flags to configure the metrics & health probes servers.
Related issue(s)
part of #16
Release Notes